PreambleAppender#appendColumns : prevent systematic table:table-column=1024 #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 14, 2024 09:03
Use TableModel#columnCapacity instead of MAX_COLUMN_COUNT in appendXMLToTable. When an ODS contains only one or few columns, it is not desirable to export the constant MAX_COLUMN_COUNT=1024 as attribute number-columns-repeated. On the other hand, the TableModel#columnCapacity knows the initial columnCapacity.
columnCapacity must be used even in the case where column headers are specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an ODS contains only one or few columns, it is not desirable to export the constant MAX_COLUMN_COUNT=1024 as attribute number-columns-repeated.
ODS readers (like SODS) will consider a generated file with 2 columns contains "rows * 1024" cells wheras it contains only "rows * 2" cells.
The TableModel#columnCapacity knows the initial columnCapacity. Using this value is more accurate.